Improve readability of test errors; update dependencies; improve test invocation #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started off just improving our newly working e2e tests, but ended up doing a few extra maint things I found useful:
BeTrue
failures more readableWaitForReady
retry loop to avoid theappscode/go
dependency (redundant + long abandoned) -> removed the dependency as a result--progress
flag--skip=Raw
for it to workNote: I'm not a huge fan of
func (...) IsPodReady(...) error
as the naming suggests a bool return value. I did try that at first, but found the bool to be redundant, since I could easily encode the message in an error, but didn't find a more suitable name for the method.