Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policy): remove readiness probe delay #13380

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(policy): remove readiness probe delay #13380

merged 1 commit into from
Nov 25, 2024

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Nov 23, 2024

The policy container is configured differently than all other controllers: other controllers configure an initialDelaySeconds on their livenessProbe but not on their readinessProbe. The policy container, however, includes this configuration on its readinessProbe but not on its livenessProbe.

This commit fixes the policy container to match the other controllers.

This reduces pod readiness time from 20s to 4s.

@olix0r olix0r requested a review from a team as a code owner November 23, 2024 18:54
@olix0r olix0r changed the title fix(policy): fix policy readiness probe delay fix(policy): remove policy readiness probe delay Nov 23, 2024
@olix0r olix0r changed the title fix(policy): remove policy readiness probe delay fix(policy): remove readiness probe delay Nov 23, 2024
The policy container is configured differently than all other controllers: other
controllers configure an `initialDelaySeconds` on their `livenessProbe` but not
on their `readinessProbe`. The policy container, however, includes this
configuration on its `readinessProbe` but not on its `livenessProbe`.

This commit fixes the policy container to match the other controllers.

This substantially reduces the time it takes for the policy container to become
ready.
@olix0r
Copy link
Member Author

olix0r commented Nov 24, 2024

Reduces start time from 20s to 4s:

On edge:

:; time (kubectl rollout restart -n linkerd deploy linkerd-destination && kubectl wait --for=condition=ready pod -l linkerd.io/control-plane-component=des
tination -n linkerd --timeout=600s) 
deployment.apps/linkerd-destination restarted
pod/linkerd-destination-7587dbfcbf-5k79q condition met
pod/linkerd-destination-5774cc74d7-rphgl condition met
( kubectl rollout restart -n linkerd deploy linkerd-destination && kubectl   )  0.23s user 0.03s system 1% cpu 20.454 total

After:

:; time (kubectl rollout restart -n linkerd deploy linkerd-destination && kubectl wait --for=condition=ready pod -l linkerd.io/control-plane-component=destination -n linkerd
 --timeout=600s)
deployment.apps/linkerd-destination restarted
pod/linkerd-destination-5c99cb9657-q877q condition met
pod/linkerd-destination-848f56c669-gpjfk condition met
( kubectl rollout restart -n linkerd deploy linkerd-destination && kubectl   )  0.24s user 0.04s system 7% cpu 3.587 total

@olix0r olix0r enabled auto-merge (squash) November 24, 2024 17:31
@olix0r olix0r merged commit 82c47a9 into main Nov 25, 2024
38 checks passed
@olix0r olix0r deleted the ver/policy-probe branch November 25, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants