Fix dual-stack integration test #12946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was sporadically failing with
```
=== RUN TestDualStack/Hit_IPv4_addr_directly
dualstack_test.go:129: expected 'IPv4', received ''
--- FAIL: TestDualStack (18.09s)
```
The problem was the ipfamilies-server pod was taking longer to become ready
than the client pod, and so the request was failing. I added a readiness
probe to the server manifest so `checkPods()` blocks until all is ready.
mateiidavid
approved these changes
Aug 8, 2024
adleong
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was sporadically failing with
The problem was the ipfamilies-server pod was taking longer to become ready than the client pod, and so the request was failing. I added a readiness probe to the server manifest so
checkPods()blocks until all is ready.