Revert "Fix destination staleness issue when adding EndpointSlices (#12427)" #12589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…12427)" This reverts commit 4fccf3e. The early return was causing `pp.addresses = newAddressSet` to not be run when the list of addresses is empty; but setting that is still necessary so that labels are tracked correctly. This was caught by the tap (viz) integration test run in the release workflow.
alpeb
changed the title
olix0r
approved these changes
May 13, 2024
adleong
approved these changes
May 13, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
May 15, 2024
…inkerd#12427)" (linkerd#12589) This reverts commit 4fccf3e. The early return was causing `pp.addresses = newAddressSet` to not be run when the list of addresses is empty; but setting that is still necessary so that labels are tracked correctly. This was caught by the tap (viz) integration test run in the release workflow. (cherry picked from commit 9bd8c00)
the-wondersmith
added a commit
to the-wondersmith/linkerd2
that referenced
this pull request
May 15, 2024
* origin/policy-feat-grpcroute-status-support: chore(ci): merge fixes from origin/main build(deps): bump tj-actions/changed-files from 44.3.0 to 44.4.0 (linkerd#12588) build(deps): bump github.com/fatih/color from 1.16.0 to 1.17.0 (linkerd#12590) chore(ci): Remove conditional integration testing (linkerd#12591) build(deps-dev): bump sinon from 17.0.1 to 17.0.2 in /web/app (linkerd#12587) build(deps): bump github.com/prometheus/client_golang (linkerd#12586) build(deps): bump thiserror from 1.0.59 to 1.0.60 (linkerd#12585) Revert "Fix destination staleness issue when adding EndpointSlices (linkerd#12427)" (linkerd#12589) Add outbound index metrics to the policy controller (linkerd#12429) build(deps): bump tj-actions/changed-files from 44.3.0 to 44.4.0 (linkerd#12588) build(deps): bump github.com/fatih/color from 1.16.0 to 1.17.0 (linkerd#12590) chore(ci): Remove conditional integration testing (linkerd#12591) build(deps-dev): bump sinon from 17.0.1 to 17.0.2 in /web/app (linkerd#12587) build(deps): bump github.com/prometheus/client_golang (linkerd#12586) build(deps): bump thiserror from 1.0.59 to 1.0.60 (linkerd#12585) Revert "Fix destination staleness issue when adding EndpointSlices (linkerd#12427)" (linkerd#12589) Set backend_not_found route status when any backends are not found (linkerd#12565) Add outbound index metrics to the policy controller (linkerd#12429) Signed-off-by: Mark S <the@wondersmith.dev>
alpeb
added a commit
that referenced
this pull request
May 20, 2024
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data. We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize `addesses` for the portPublisher. This just removes the early return.
alpeb
added a commit
that referenced
this pull request
May 20, 2024
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data. We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize `addesses` for the portPublisher. This just removes the early return.
alpeb
added a commit
that referenced
this pull request
May 20, 2024
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data. We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize `addesses` for the portPublisher. This just removes the early return.
alpeb
added a commit
that referenced
this pull request
May 22, 2024
This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data. We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize `addesses` for the portPublisher. This just removes the early return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4fccf3e.
The early return was causing
pp.addresses = newAddressSetto not be run when the list of addresses is empty; but setting that is still necessary so that labels are tracked correctly.This was caught by the tap (viz) integration test run in the release workflow.