feat(destination): add resource metadata to responses #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination service does no include resource coordinates, so the proxy must "guess" them by parsing hostnames, which is not particularly reliable or efficient. This change updates the destination API so that profile responses may include resource reference to (1) parent Services, (2) ServiceProfile resources and (3) backend Services. Furthermore, the WeightedAddr type is updated to include a resource reference so that Pod coordinates may be referenced. This metadata is not required to be set (for backwards compatibility).
adleong
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination service does no include resource coordinates, so the proxy must "guess" them by parsing hostnames, which is not particularly reliable or efficient.
This change updates the destination API so that profile responses may include resource reference to (1) parent Services, (2) ServiceProfile resources and (3) backend Services. Furthermore, the WeightedAddr type is updated to include a resource reference so that Pod coordinates may be referenced.
This metadata is not required to be set (for backwards compatibility).