Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to support recovering from replica addition failure #1382

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

jsjtzyy
Copy link
Contributor

@jsjtzyy jsjtzyy commented Feb 12, 2020

This PR adds minor changes to resume dynamic replica addition if it failed last time before updating InstanceConfig(clustermap update in Helix). The logic is simple: if diskManager finds there is a existing
directory associated with replica to add, it first deletes it and recreates a new one. (The files in previous directory may not be reliable)

This PR adds minor changes to resume dynamic replica addition if it
failed last time before updating InstanceConfig(clustermap update in
Helix). The logic is simple: if diskManager finds there is a existing
dir associated with replica to add, it first deletes it and recreates a
new one. (The files in previous dir may not be reliable)
@jsjtzyy jsjtzyy requested a review from ankagrawal February 12, 2020 18:53
@jsjtzyy jsjtzyy self-assigned this Feb 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #1382 into master will decrease coverage by 0.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1382      +/-   ##
============================================
- Coverage     72.35%   72.34%   -0.02%     
- Complexity     6867     6868       +1     
============================================
  Files           496      496              
  Lines         38854    38862       +8     
  Branches       4940     4941       +1     
============================================
+ Hits          28113    28114       +1     
- Misses         9383     9388       +5     
- Partials       1358     1360       +2
Impacted Files Coverage Δ Complexity Δ
...in/java/com.github.ambry.store/StorageManager.java 88.84% <ø> (ø) 54 <0> (ø) ⬇️
.../main/java/com.github.ambry.store/DiskManager.java 88.28% <62.5%> (-0.84%) 55 <0> (ø)
.../com.github.ambry.network/BlockingChannelInfo.java 80.95% <0%> (-3.18%) 16% <0%> (ø)
...github.ambry.rest/AsyncRequestResponseHandler.java 87.87% <0%> (-2.36%) 21% <0%> (ø)
...b.ambry.network/BlockingChannelConnectionPool.java 73.68% <0%> (-2.11%) 11% <0%> (-1%)
...ain/java/com.github.ambry.router/PutOperation.java 91.4% <0%> (-0.5%) 115% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.04% <0%> (ø) 103% <0%> (ø) ⬇️
...c/main/java/com.github.ambry.network/Selector.java 79% <0%> (+0.78%) 78% <0%> (+1%) ⬆️
...va/com.github.ambry.replication/ReplicaThread.java 87.54% <0%> (+0.92%) 95% <0%> (+2%) ⬆️
...java/com.github.ambry.store/CompactionManager.java 92.26% <0%> (+2.38%) 25% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f407d1...b1b3eb9. Read the comment docs.

Copy link
Collaborator

@ankagrawal ankagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankagrawal ankagrawal merged commit 042bcd5 into linkedin:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants