Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to connect to Cosmos with DirectHttps mode #1243

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

lightningrob
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1243 into master will decrease coverage by 0.06%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1243      +/-   ##
============================================
- Coverage     72.22%   72.16%   -0.07%     
+ Complexity     6045     6039       -6     
============================================
  Files           439      439              
  Lines         34910    34914       +4     
  Branches       4430     4431       +1     
============================================
- Hits          25214    25195      -19     
- Misses         8546     8562      +16     
- Partials       1150     1157       +7
Impacted Files Coverage Δ Complexity Δ
...ithub.ambry.cloud/azure/AzureCloudDestination.java 80.45% <0%> (-0.94%) 42 <0> (ø)
...com.github.ambry.cloud/azure/AzureCloudConfig.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...in/java/com.github.ambry.clustermap/Partition.java 78.16% <0%> (-3.45%) 26% <0%> (-1%)
.../com.github.ambry.network/BlockingChannelInfo.java 82.25% <0%> (-3.23%) 16% <0%> (-1%)
...java/com.github.ambry.store/CompactionManager.java 88.88% <0%> (-2.62%) 22% <0%> (ø)
...java/com.github.ambry.network/SSLTransmission.java 70.87% <0%> (-2.27%) 70% <0%> (-1%)
.../java/com.github.ambry.router/DeleteOperation.java 93.28% <0%> (-1.5%) 44% <0%> (-1%)
...c/main/java/com.github.ambry.network/Selector.java 79.48% <0%> (-0.86%) 73% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.83% <0%> (-0.63%) 103% <0%> (ø)
...rc/main/java/com.github.ambry.store/BlobStore.java 89.58% <0%> (-0.25%) 92% <0%> (-1%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5edba...f7002ee. Read the comment docs.

@@ -13,3 +13,4 @@ azure.storage.connection.string=<storage-account-credentials>
cosmos.endpoint=<cosmos-url>
cosmos.collection.link=/dbs/ambry-metadata/colls/blob-metadata
cosmos.key=<cosmos-key>
cosmos.direct.https=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: do we need to specify this in the sample properties file?

@ankagrawal ankagrawal merged commit 8f671c9 into linkedin:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants