Misc fixes in cluster manager, replication and compaction manager #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=========================================
Coverage 88.92% 88.92%
Complexity 60 60
=========================================
Files 6 6
Lines 352 352
Branches 37 37
=========================================
Hits 313 313
Misses 29 29
Partials 10 10Continue to review full report at Codecov.
|
justinlin-linkedin
approved these changes
Aug 15, 2019
| @@ -1245,10 +1245,12 @@ public void sendResponse(Send payloadToSend, Request originalRequest, ServerNetw | |||
| * An empty {@link Store} implementation. | |||
| */ | |||
| private Store store = new Store() { | |||
| boolean started; | |||
1. Set DEBUG and TRACE log level in Histogram dumper 2. Fixed race condition in compaction manager test 3. Printed out remote dc exception during helix cluster manager initialization (previously it was swallowed and hard to debug) 4. Moved partition lag update operatio to exchange metadata method in replication manager 5. Paused replication on store that is not started. Replication can resume if store is restarted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialization (previously it was swallowed and hard to debug)
replication manager
resume if store is restarted.