Add off switch for replenishConnections and honor datanode health #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make connection replenishment configurable and off by default. Avoid trying to initiate connections with nodes detected as down.
jsjtzyy
approved these changes
Jun 21, 2019
| networkMetrics.connectionReplenished.inc(connectionsInitiated); | ||
| if (networkConfig.networkClientEnableConnectionReplenishment) { | ||
| int connectionsInitiated = connectionTracker.replenishConnections(this::connect); | ||
| networkMetrics.connectionReplenished.inc(connectionsInitiated); |
There was a problem hiding this comment.
minor: do you need to update networkMetrics.connectionReplenished in method warmUpConnections as well?
There was a problem hiding this comment.
I think it is better to have this metric only apply to connections replenished in sendAndPoll
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=========================================
Coverage 83.62% 83.62%
Complexity 57 57
=========================================
Files 6 6
Lines 348 348
Branches 38 38
=========================================
Hits 291 291
Misses 45 45
Partials 12 12Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make connection replenishment configurable and off by default.
Avoid trying to initiate connections with nodes detected as down.