Add configurable warm up for remote datacenter connections #1198
Conversation
Previously, only local datacenter connections could be prewarmed in the router. This adds a new config to allow prewarming remote datacenter connections. This could be useful in deployments where cross-DC requests are likely.
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
=========================================
Coverage 83.62% 83.62%
Complexity 57 57
=========================================
Files 6 6
Lines 348 348
Branches 38 38
=========================================
Hits 291 291
Misses 45 45
Partials 12 12Continue to review full report at Codecov.
|
|
|
||
| /** | ||
| * The percentage of {@link RouterConfig#routerScalingUnitMaxConnectionsPerPortSsl} or | ||
| * {@link RouterConfig#routerScalingUnitMaxConnectionsPerPortPlainText} to warm up for data nodes in the local |
There was a problem hiding this comment.
The comments for routerConnectionsRemoteDcWarmUpPercentage need to be changed perhaps!
| routerConnectionsLocalDcWarmUpPercentage = | ||
| verifiableProperties.getIntInRange("router.connections.local.dc.warm.up.percentage", 25, 0, 100); | ||
| routerConnectionsRemoteDcWarmUpPercentage = | ||
| verifiableProperties.getIntInRange("router.connections.remote.dc.warm.up.percentage", 0, 0, 100); |
There was a problem hiding this comment.
Should the default value be 25 here? We are setting default in the declaration decorator to 25.
There was a problem hiding this comment.
ah thanks for catching that. The default should be 0 since I feel that warming up cross DC connections only applies to specific ambry use cases, but I will fix the decorator.
Previously, only local datacenter connections could be prewarmed in the
router. This adds a new config to allow prewarming remote datacenter
connections. This could be useful in deployments where cross-DC requests
are likely.