-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource control enable/disable #1179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1179 +/- ##
==========================================
- Coverage 69.69% 69.6% -0.1%
+ Complexity 5397 5396 -1
==========================================
Files 430 430
Lines 33015 33047 +32
Branches 4173 4176 +3
==========================================
- Hits 23010 23001 -9
- Misses 8869 8906 +37
- Partials 1136 1140 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments/questions, otherwise looks good.
ambry-tools/src/main/java/com.github.ambry/clustermap/HelixVcrPopulateTool.java
Outdated
Show resolved
Hide resolved
* @param resourceName the resource to enable/disable | ||
* @param enable enable the resource if true | ||
*/ | ||
static void controlResource(String destZkString, String destClusterName, String resourceName, boolean enable) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible to add tests for the new methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not easy, since helix library doesn't expose getMethod for these status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. But it's still good to test the different options to get code coverage.
Fix some issue in #1176
Add controlResource and maintainCluster support.