Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set network proxy in config rather than jvm args #1155

Merged
merged 6 commits into from
Apr 16, 2019

Conversation

lightningrob
Copy link
Contributor

No description provided.

@lightningrob lightningrob requested review from jsjtzyy and zzmao April 16, 2019 01:43
@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #1155 into master will decrease coverage by 0.05%.
The diff coverage is 52.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1155      +/-   ##
============================================
- Coverage      69.6%   69.55%   -0.06%     
+ Complexity     5248     5242       -6     
============================================
  Files           414      414              
  Lines         32323    32334      +11     
  Branches       4112     4113       +1     
============================================
- Hits          22500    22490      -10     
- Misses         8704     8717      +13     
- Partials       1119     1127       +8
Impacted Files Coverage Δ Complexity Δ
...in/java/com.github.ambry.cloud/CloudBlobStore.java 73% <100%> (ø) 18 <0> (ø) ⬇️
...main/java/com.github.ambry/config/CloudConfig.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...com.github.ambry.cloud/azure/AzureCloudConfig.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...mbry.cloud/azure/AzureCloudDestinationFactory.java 66.66% <20%> (-22.23%) 3 <1> (ø)
...ithub.ambry.cloud/azure/AzureCloudDestination.java 81.29% <51.61%> (+0.75%) 19 <2> (ø) ⬇️
.../main/java/com.github.ambry.store/ScanResults.java 81.25% <0%> (-3.13%) 16% <0%> (-2%)
...java/com.github.ambry.network/BlockingChannel.java 78.87% <0%> (-2.82%) 9% <0%> (-1%)
...b.ambry.network/BlockingChannelConnectionPool.java 70.43% <0%> (-1.74%) 9% <0%> (ø)
...in/java/com.github.ambry.store/BlobStoreStats.java 71.13% <0%> (-1.65%) 103% <0%> (-2%)
...va/com.github.ambry.replication/ReplicaThread.java 75.14% <0%> (-0.4%) 62% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7769142...545880a. Read the comment docs.

Copy link
Contributor

@zzmao zzmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments.

Copy link
Contributor

@jsjtzyy jsjtzyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have too much context of this PR. Only a few minor comments based on a cursory look. We can approve this after @zzmao 's comments are addressed.

@lightningrob
Copy link
Contributor Author

Note: travis build failing due to Oracle JDK8 download. Sent email to travis support about it.
Ran gradle build/test locally and passed.

Copy link
Contributor

@zzmao zzmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zzmao zzmao merged commit 7ab285a into linkedin:master Apr 16, 2019
@lightningrob lightningrob deleted the proxyfix branch January 15, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants