-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set network proxy in config rather than jvm args #1155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
============================================
- Coverage 69.6% 69.55% -0.06%
+ Complexity 5248 5242 -6
============================================
Files 414 414
Lines 32323 32334 +11
Branches 4112 4113 +1
============================================
- Hits 22500 22490 -10
- Misses 8704 8717 +13
- Partials 1119 1127 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/test/java/com.github.ambry.cloud/azure/AzureCloudDestinationTest.java
Show resolved
Hide resolved
ambry-cloud/src/test/java/com.github.ambry.cloud/azure/AzureIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have too much context of this PR. Only a few minor comments based on a cursory look. We can approve this after @zzmao 's comments are addressed.
ambry-api/src/main/java/com.github.ambry/config/CloudConfig.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudConfig.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Outdated
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java
Show resolved
Hide resolved
ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestinationFactory.java
Outdated
Show resolved
Hide resolved
Note: travis build failing due to Oracle JDK8 download. Sent email to travis support about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.