Skip to content

Commit

Permalink
Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
justinlin-linkedin committed Aug 15, 2019
1 parent 960e0f5 commit d0efbc4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,20 @@
* An AccountMetadataStore is a storage to keep and retrieve {@link Account} metadata. This is the base
*/
abstract class AccountMetadataStore {
private static final Logger logger = LoggerFactory.getLogger(LegacyMetadataStore.class);
private static final Logger logger = LoggerFactory.getLogger(AccountMetadataStore.class);

protected final AccountServiceMetrics accountServiceMetrics;
protected final LocalBackup backup;
protected final String znRecordPath;
private final HelixPropertyStore<ZNRecord> helixStore;
private final ReentrantLock lock = new ReentrantLock();

/** Create a new {@link AccountMetadataStore} instance for the subclasses.
* @param accountServiceMetrics The {@link AccountServiceMetrics}
* @param backup The {@link LocalBackup} to manage the backup files.
* @param helixStore The {@link HelixPropertyStore} to retrieve and update the {@link ZNRecord}.
* @param znRecordPath The {@link ZNRecord} path.
*/
AccountMetadataStore(AccountServiceMetrics accountServiceMetrics, LocalBackup backup,
HelixPropertyStore<ZNRecord> helixStore, String znRecordPath) {
this.accountServiceMetrics = accountServiceMetrics;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ public LocalBackup(AccountServiceMetrics accountServiceMetrics, HelixAccountServ
}

/**
* Reserve a new one with the following file name format: {@code {yyyyMMdd}T{HHmmss}.{unique long}.old}.
* Reserve a new backup file with the following file name format: {@code {yyyyMMdd}T{HHmmss}.{unique long}.old}.
* @return a {@link Pair} containing the unique filename prefix for this account update and the path to use for
* previous state backups.
* @throws IOException
Expand Down

0 comments on commit d0efbc4

Please sign in to comment.