Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI !config command #43

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add CLI !config command #43

merged 1 commit into from
Aug 7, 2023

Conversation

ryannedolan
Copy link
Collaborator

Added new CLI command !config, enabling users to dynamically tweak configuration properties. These are then visible within templates, e.g. as rendered by the !yaml command.

Added a new constructor to HoptimatorCliApp, enabling client code to provide custom configuration.

Testing Done

Rendering YAML with the !yaml command may result in unexpanded variables, e.g. {{pipeline.namespace}}:

> !yaml insert into ...
--->%---
  namespace: {{pipeline.namespace}}
--->%---

With the new !config command, we can specify these variables dynamically:

> !config pipeline.namespace=testing-123
> !yaml insert into ...
--->%---
  namespace: testing-123
--->%---

@ryannedolan ryannedolan requested a review from HuiWang1020 August 7, 2023 22:15
@ryannedolan ryannedolan merged commit b7c6a9d into main Aug 7, 2023
@ryannedolan ryannedolan deleted the cli-env branch August 7, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants