Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure render of I18nProvider in async scenarios #839

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Ensure render of I18nProvider in async scenarios #839

merged 3 commits into from
Nov 9, 2020

Commits on Nov 9, 2020

  1. Ensure makeContext() gets called in useEffect hook

    @Bertg
    Bertg committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e5785df View commit details
    Browse the repository at this point in the history

  2. Improve render logic on async 

    prevent extra re-render by checking if it is required
    @Bertg
    Bertg committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    3700f61 View commit details
    Browse the repository at this point in the history

  3. Add a warning when I18nProvider does not render

    @Bertg
    Bertg committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    934639d View commit details
    Browse the repository at this point in the history