fix: accept catalog paths without ending slash #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/ahszchsqz |
tricoder42
approved these changes
Nov 2, 2020
|
Looks good! Honestly, I don't need to see a benchmark. If you want to refactor it and you know that it's faster, then it's fine. |
ThiefMaster
added a commit
to ThiefMaster/js-lingui
that referenced
this pull request
Nov 2, 2020
The missing `mockFs.restore()` in lingui#812 broke snapshot tests rather badly. Existing tests did not fail, but no new snapshots were written, and every test run created new ones (in some temp location).
ThiefMaster
added a commit
to ThiefMaster/js-lingui
that referenced
this pull request
Nov 2, 2020
The missing `mockFs.restore()` in lingui#812 broke snapshot tests rather badly. Existing tests did not fail, but no new snapshots were written, and every test run created new ones (in some temp location).
Merged
tricoder42
pushed a commit
that referenced
this pull request
Nov 2, 2020
The missing `mockFs.restore()` in #812 broke snapshot tests rather badly. Existing tests did not fail, but no new snapshots were written, and every test run created new ones (in some temp location).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #809
Added mark: true to node-glob because internally node-glob needs an slash at the end, will be the same of running normalizeRelativePaths to exclude array
I want to (if you are agree of course) migrate node-glob to fdir that is significantly more faster, will work on it with some benchmarks this week 👍🏻