fix: flow typing of React API with Flow 0.92

[4ian]

Nice library! ;) Very well done :D

I've run into a few flow errors when trying to add it on my project (https://github.com/4ian/GDevelop) with Flow 0.92.
I've made a few fixes, hope they are ok.

Changes

• I'm not sure about LinguiPublisher, I think it should be named createLinguiPublisher or makeLinguiPublisher as it's returning an object rather than being a constructor (i.e: it's not modifying this). I've changed the name and changed its usage to remove the new.
  • I've not seen any reference to LinguiPublisher when googling it. If you think this is breaking the API, we can go back to have it being named LinguiPublisher and have the type named LinguiPublisherType.
• A test case is there to ensure update of LinguiPublisher can be called without any arguments. But the typing was incorrect then. I've named the parameter (param, not very original) and checked for its existence before destructuring it.
• A few || null to ensure you're not returning undefined in renders.

Test plan

• Ran yarn lint and got in pseudoLocalize.test.js:

  38:22  error  Replace "{count,·plural,·one·{{countString}·book}·other·{{countString}·books}}" with ⏎········"{count,·plural,·one·{{countString}·book}·other·{{countString}·books}}"⏎······  prettier/prettier
  39:15  error  Replace "{count,·plural,·one·{{countString}·ƀōōķ}·other·{{countString}·ƀōōķś}}" with ⏎······"{count,·plural,·one·{{countString}·ƀōōķ}·other·{{countString}·ƀōōķś}}"⏎····      prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the --fix option.

but this seems to be unrelated to my changes?

• yarn flow is still passing.
• flow (with flow version 0.92.0) is down from 5 errors to 2, that are in packages/cli/src/api/compile.js (line 142 and 144):

Cannot call pseudoLocalize with translation bound to message because MessageType [1] is incompatible with string [2].

I've not fixed them because my goal was to get the React API without flow errors :) Original errors where (when using js-lingui in a React project):

Also if you feel more comfortable fixing yourself the issues with Flow 0.92 rather than merging/asking changes on this PR, feel free to steal my fixes :)

[4ian]

(Failing tests seems due to a memory error - transient issue?)

[tricoder42]

Hey @4ian, thanks! Yeah, you made good points! The CI is broken since Node.js 10.something when mock-fs stopped to work :/ I didn't have enough time to fix this as I'm working on v3...

[4ian]

No worries, and thanks for your work on this! Look forward to see v3 😃

[tricoder42]

Released in 2.7.4