Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): nextjs app router example #1944

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented May 28, 2024

Description

This migrates the existing nextjs app to use app router, next to pages router.

The idea is to merge this (the 2 commits as they are) and then the tutorial will point to the second commit that did the migration work, and people can then replicate it in their migrations.

For those that want to just see the app router integration, they can do so by looking into the app router directory.

This also means that maintainers have one project to worry about as opposed to having an example for app router, pages router, babel, swc...

I'm not yet entirely happy about how the pages router is integrating lingui but that's something for later

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 9:10am

Copy link

github-actions bot commented May 28, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@vonovak vonovak marked this pull request as ready for review May 29, 2024 09:51
@andrii-bodnar andrii-bodnar changed the title feat: nextjs app router example docs: nextjs app router example May 29, 2024
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak looks good to me, thanks a lot! 🚀

P.S. I updated the PR title feat -> docs because it actually does not bring any features into the tool, but it will increment the minor version during the release.

@andrii-bodnar andrii-bodnar changed the title docs: nextjs app router example docs(examples): nextjs app router example May 29, 2024
@dominik-sfl
Copy link

When will this be merged? Would love to see it on the site.

@andrii-bodnar andrii-bodnar merged commit 30dab4e into main Jun 11, 2024
21 checks passed
@andrii-bodnar andrii-bodnar deleted the feat/app-router-example branch June 11, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants