-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): nextjs app router example #1944
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
e5f5201
to
6193923
Compare
c6923d7
to
b854418
Compare
b854418
to
100fc74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vonovak looks good to me, thanks a lot! 🚀
P.S. I updated the PR title feat
-> docs
because it actually does not bring any features into the tool, but it will increment the minor version during the release.
When will this be merged? Would love to see it on the site. |
Description
This migrates the existing nextjs app to use app router, next to pages router.
The idea is to merge this (the 2 commits as they are) and then the tutorial will point to the second commit that did the migration work, and people can then replicate it in their migrations.
For those that want to just see the app router integration, they can do so by looking into the
app
router directory.This also means that maintainers have one project to worry about as opposed to having an example for app router, pages router, babel, swc...
I'm not yet entirely happy about how the pages router is integrating lingui but that's something for later
Types of changes
Fixes # (issue)
Checklist