-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for culture #167
Conversation
The tests are passing on my machine, probably the runtime is different on the CI machines. One failure is related to the german culture (de-DE) which doesn't seams to be supported and the numerals are formatted using the english (en-UK) version. The second one is even more interesting... I'm investigating both issues, but suggestions are welcome! |
Hi @cristiingineru, |
…es and pass the path to icu using argument instead of env variable
Hi @tricoder42! Do you have any time limits on any of the CI services? Each debug attempt to try something new will trigger other builds and I don't want to cause any issues. I noticed CircleCI has debug capabilities with SSH, so I'll try to debug the issue on one of my dummy repos which is also connected to CircleCI, but I never used SSH with this service yet and not sure I'll be able to reproduce the same condition as of this repo. |
I've messed up this branch so badly, but I've figured it out how to set up the full-icu correctly and make the test pass. I'm going to close this PR and open a new one. Sorry for this mess! |
No problem at all. You could simply squash commits in your branch and force-push it. |
Sorry I wasn't any help in last days :/ I'm available in next 2 hours, ping me if you need anything. Looking forward to your PR! |
There are multiple types of numerals, even the arabic numberals have multiple representations: https://en.wikipedia.org/wiki/Eastern_Arabic_numerals#Numerals
This change is adding support for different type of "cultures" by taking advantage of the standard Intl.NumberFormat
The language itself is not enough to format the numerals because there are languages which support multiple formats.
Questions:
locales
andoptions
- be further exposed through the js-lingui API?locales
be further exposed aslocales
orculture
? Other languages are using culture, or cultureNames...i18n
?