fix: just use require to import services #1647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
from #1631, there is error importing TranslationIO service with
import
. It result inCannot find module
. The problem is that it need the js extension.One solution is to add js extension
import('xxx' + .js)
, but the result would still need to beNot sure why the double default there, but using require would solve at least the double default.
Types of changes
Fixes # (issue)
#1631
Checklist