Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version in examples #1621

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

andrii-bodnar
Copy link
Contributor

Description

Use the newest version in the example projects

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 0:31am

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a79de75) 75.56% compared to head (25c199c) 75.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   75.56%   75.56%           
=======================================
  Files          79       79           
  Lines        2018     2018           
  Branches      519      519           
=======================================
  Hits         1525     1525           
  Misses        379      379           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar
Copy link
Contributor Author

@thekip do you have any ideas why the release test WF is failing here? https://github.com/lingui/js-lingui/actions/runs/4808463649/jobs/8558583109?pr=1621

@andrii-bodnar
Copy link
Contributor Author

#1633

@timofei-iatsenko
Copy link
Collaborator

@andrii-bodnar CRA uses jest 27.* which doesn't have support for package.json exports conditions.

There is opened pull request in their's repo facebook/create-react-app#12662

@andrii-bodnar andrii-bodnar force-pushed the chore/bump-version-in-examples branch from 5c49294 to 25c199c Compare May 19, 2023 12:28
@andrii-bodnar andrii-bodnar merged commit a8ba277 into main May 19, 2023
@andrii-bodnar andrii-bodnar deleted the chore/bump-version-in-examples branch May 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants