Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update lingui import statement in setup-vite.md #1552

Merged
merged 1 commit into from
Mar 22, 2023
Merged

docs: Update lingui import statement in setup-vite.md #1552

merged 1 commit into from
Mar 22, 2023

Conversation

goibon
Copy link
Contributor

@goibon goibon commented Mar 22, 2023

Description

Since #1465 changed the default export from @lingui/vite-plugin to a named export, the setup guide for vite is outdated and can't be used without knowledge that you need to rewrite the import statement.
This PR updates the setup guide to correctly reflect this change.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@goibon
Update lingui import statement in setup-vite.md
33dce23 
Updated the Vite setup guide to used the named export from `@lingui/vite-plugin` instead of the default.
@vercel
Copy link

vercel bot commented Mar 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 2:36PM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.76 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.78 KB (0%)
./packages/remote-loader/build/esm/index.js 7.29 KB (0%)

@goibon goibon changed the title Update lingui import statement in setup-vite.md docs: Update lingui import statement in setup-vite.md Mar 22, 2023
@andrii-bodnar
Copy link
Contributor

@goibon thanks a lot for your contribution!

@andrii-bodnar andrii-bodnar merged commit 5533437 into lingui:main Mar 22, 2023
@goibon goibon deleted the patch-1 branch March 22, 2023 17:05
andrii-bodnar added a commit that referenced this pull request Mar 24, 2023
@andrii-bodnar
Merge branch 'main' into next
43c65f6 
docs(vite-setup): add missing dependencies and show ts configuration (#1556)
Update lingui import statement in setup-vite.md (#1552)
fix(react): remove deprecated defaultProps from Trans cmp (#1494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goibon @andrii-bodnar