Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not ignore empty plural values #1504

Merged
merged 3 commits into from
Mar 13, 2023

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Mar 11, 2023

Description

It's a corner case but I think the test case explains it

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 11:34PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 11, 2023

size-limit report 📦

Path Size
./packages/core/build/esm/index.js 1.56 KB (0%)
./packages/detect-locale/build/esm/index.js 812 B (0%)
./packages/react/build/esm/index.js 1.79 KB (0%)
./packages/remote-loader/build/esm/index.js 7.25 KB (0%)

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (32c7f91) 73.93% compared to head (4ced4a8) 73.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1504      +/-   ##
==========================================
+ Coverage   73.93%   73.98%   +0.05%     
==========================================
  Files          67       67              
  Lines        1872     1872              
  Branches      493      493              
==========================================
+ Hits         1384     1385       +1     
  Misses        383      383              
+ Partials      105      104       -1     
Impacted Files Coverage Δ
packages/core/src/formats.ts 96.87% <100.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko
Copy link
Collaborator

LGTM! Thanks for contribution

@andrii-bodnar
Copy link
Contributor

@vonovak thank you!

@andrii-bodnar andrii-bodnar merged commit 3d07510 into lingui:next Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants