Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloud service import() on case-sensitive filesystems #1174

Merged
merged 3 commits into from
Dec 7, 2021

Conversation

MichaelHoste
Copy link
Contributor

We found an issue on case sensitive systems where the cloud service (if one was present) was not loading correctly.

We made sure to lowercase the first letter so that it works on both case-sensitive and case-insensitive systems.

@vercel
Copy link

vercel bot commented Dec 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/8D3qqJnJUNLo88iAFmmn7z1KdLrp
✅ Preview: Failed

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1174 (19a64a1) into main (1c8e657) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files          56       56           
  Lines        1766     1766           
  Branches      490      490           
=======================================
  Hits         1443     1443           
  Misses        192      192           
  Partials      131      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987b5c4...19a64a1. Read the comment docs.

@semoal
Copy link
Contributor

semoal commented Dec 7, 2021

Hi 👋 Michaël! LGTM, will release a new version today

@semoal semoal changed the title Fix cloud service import() on case-sensitive filesystems fix: cloud service import() on case-sensitive filesystems Dec 7, 2021
@semoal semoal merged commit 5feb120 into lingui:main Dec 7, 2021
@MichaelHoste
Copy link
Contributor Author

Thanks a lot for your quick response @semoal ! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants