Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hinting whilst a VariableLabel animation is ongoing #535

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 22, 2024

If using hinting during an animation, a shimmering effect can occur.

Copy link
Contributor

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the choppiness that I was experiencing earlier. It works perfectly on Windows and Mac.

@DJMcNab
Copy link
Member Author

DJMcNab commented Aug 23, 2024

Hmm, I'm surprised. I didn't think this had any impact on example directly...
Are you sure you're still seeing the choppiness on main?

@jaredoconnell
Copy link
Contributor

Hmm, I'm surprised. I didn't think this had any impact on example directly... Are you sure you're still seeing the choppiness on main?

Ah. You are correct. In which case, I can confirm that I cannot spot any regressions in the example.

@DJMcNab
Copy link
Member Author

DJMcNab commented Aug 23, 2024

Grand! No big surprises here, but this is the right behaviour. See also linebender/vello#204 for the explanation of the shimmering.

This is more important once googlefonts/fontations#1083 lands.

(@dfrg would it be useful for you if I hooked that up in Vello for testing?)

@DJMcNab DJMcNab added this pull request to the merge queue Aug 23, 2024
Merged via the queue into linebender:main with commit c77c6ec Aug 23, 2024
17 checks passed
@DJMcNab DJMcNab deleted the taking branch August 23, 2024 17:39
@dfrg
Copy link
Contributor

dfrg commented Aug 24, 2024

(@dfrg would it be useful for you if I hooked that up in Vello for testing?)

I appreciate the offer but that work is still in flux so it’s probably best to wait for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants