New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode alpha for Images #692

Open

DJMcNab opened this issue Sep 20, 2024 · 0 comments

Member

DJMcNab commented Sep 20, 2024 •

edited

Loading

Currently, when encoding an image, the alpha factor is discarded:

vello/vello_encoding/src/encoding.rs

Lines 421 to 423 in e777e08

    
           pub fn encode_image(&mut self, image: &Image, _alpha: f32) { 
        
               // TODO: feed the alpha multiplier through the full pipeline for consistency 
        
               // with other brushes?

The consequences of this are:

DrawGlyphs::brush_alpha doesn't work for bitmap glyphs
The alpha factor on Peniko's Image type is not handled - Rename with_alpha_factor to multiply_alpha peniko#52

To fix this, we need to wire this alpha through to fine (because of #664 and friends), somehow.

The text was updated successfully, but these errors were encountered:

DJMcNab mentioned this issue

Update Peniko to 0.2.0 #693

Merged

github-merge-queue bot pushed a commit that referenced this issue


          Update Peniko to 0.2.0 (#693)

3bf5428

This updates Peniko to
[0.2.0](https://github.com/linebender/peniko/releases/tag/v0.2.0).

The main impact this would have on users is being able to set `alpha` on
images, but that is currently broken because of #692.

This also updates to Kurbo
[0.11.1](https://github.com/linebender/kurbo/releases/tag/v0.11.1),
which of note includes linebender/kurbo#353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment