Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root without xmlns #892

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Root without xmlns #892

merged 3 commits into from
Mar 3, 2025

Conversation

JosefKuchar
Copy link
Contributor

Closes #847

This PR implements support for SVG files without xmlns tag.
Existing tests pass.

LaurenzV
LaurenzV approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@LaurenzV LaurenzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me in principal to not be too strict here, but would like to see approval from one other person before merging.

@RazrFalcon
Copy link
Collaborator

Should be fine I guess. Hard to tell.

@LaurenzV LaurenzV merged commit 6debc44 into linebender:main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenzV LaurenzV LaurenzV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usvg fails to parse SVGs if xmlns attribute is missing
3 participants
@JosefKuchar @RazrFalcon @LaurenzV