usage of cargo clippy --fix --lib -p usvg with rust 1.83.0
#876
+57
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mothsART
force-pushed
the
feature/cargo-clippy
branch
from
f07d790 to
f943fe3
Compare
DJMcNab
reviewed
Jan 6, 2025
Comment on lines
57
to
+60
| clip_path = convert(link, state, object_bbox, cache); | ||
|
|
||
| // Linked `clipPath` must be valid. | ||
| if clip_path.is_none() { | ||
| return None; | ||
| } | ||
| clip_path.as_ref()?; |
There was a problem hiding this comment.
I don't think this is better. If you do want to change this, I'd say:
// Bail out if the linked clip path is invalid
let clip_path_attr = convert(...)?;
clip_path = Some(clip_path_attr);But I think the original code is fine...
| @@ -331,7 +331,7 @@ fn convert_stops(grad: SvgNode) -> Vec<Stop> { | |||
| if stops.len() >= 3 { | |||
| let mut i = 0; | |||
| while i < stops.len() - 2 { | |||
| let offset1 = stops[i + 0].offset.get(); | |||
| let offset1 = stops[i].offset.get(); | |||
There was a problem hiding this comment.
Again... I can see the rationale, but I think the previous version was probably better.
| @@ -1418,7 +1418,7 @@ fn shape_text_with_font( | |||
|
|
|||
| glyphs.push(Glyph { | |||
| byte_idx: ByteIndex::new(idx), | |||
| cluster_len: end.checked_sub(start).unwrap_or(0), // TODO: can fail? | |||
| cluster_len: end.saturating_sub(start), // TODO: can fail? | |||
There was a problem hiding this comment.
The semantics are the same, but the meaning this suggests to the reader is different
My understanding was that all of these are changes automatically applied by clippy, no? 😄 In which case we probably would have to adapt which lints we want to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests that include: