Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement checking if the font familly exists in pango #455

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update piet-cairo/src/text.rs
Co-authored-by: Colin Rofls <colin@cmyr.net>
JAicewizard and cmyr authored Jul 15, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 43796b350e2e1f916c1b931631c695d686396b34
3 changes: 1 addition & 2 deletions piet-cairo/src/text.rs
Original file line number Diff line number Diff line change
@@ -167,8 +167,7 @@ impl Text for CairoText {
type TextLayoutBuilder = CairoTextLayoutBuilder;

fn font_family(&mut self, family_name: &str) -> Option<FontFamily> {
// The pango documentation says this is always a stirng, and never null. I trust them on that.
// Would be weird to have a font family without a name anyways.
// The pango documentation says this is always a string, and never null.
self.pango_context
.list_families()
.iter()