Limit the timing of git submodule updates by renovate to avoid disrupting work during working hours #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id disrupting work during working hours
Yang-33
commented
Jan 16, 2025
| "extends": [ | ||
| "config:base" | ||
| ], | ||
| "timezone": "Asia/Tokyo", |
There was a problem hiding this comment.
diff may not work but changes are just
- rename renovate.json to renovate.json5 to write comment
- add
timezoneandpackageRules[].schedule
This was referenced Jan 16, 2025
eucyt
approved these changes
Jan 16, 2025
Yang-33
added a commit
to line/line-bot-sdk-nodejs
that referenced
this pull request
Jan 16, 2025
…ting work during working hours (#1126) same: line/line-bot-sdk-python#743
Yang-33
added a commit
to line/line-bot-sdk-php
that referenced
this pull request
Jan 16, 2025
…ting work during working hours (#649) same: line/line-bot-sdk-python#743
Yang-33
added a commit
to line/line-bot-sdk-java
that referenced
this pull request
Jan 16, 2025
…ting work during working hours (#1524) same: line/line-bot-sdk-python#743
Yang-33
added a commit
to line/line-bot-sdk-go
that referenced
this pull request
Jan 16, 2025
…ting work during working hour (#528) same: line/line-bot-sdk-python#743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating line-openapi, there are times when both
are generated simultaneously.
This change is to avoid that. Usually, when it's known that the bot SDK code will be changed (which is most cases), (1) is not necessary because the operator dispatches the workflow to change the code.
In particular, since the operator usually dispatches the workflow for 6 bot sdk repositories via a script, the PRs automatically created by Renovate are a hindrance.
However, to account for the possibility that the operator might simply forget to update bot sdk code, I've restricted Renovate to update the git submodule only at night instead of not updating. This way, if code generation is forgotten, it can be noticed the next day.
(Other options) It was also possible to change the GitHub workflow to prevent duplicate PR by using same branch, but if the operator forgets to update for a while, there will be multiple features changed in one PR. I don't like this. though both options are fine, I think this PR is more suitable for our work at the moment rather than this option.