Change __version__ on release #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yang-33
changed the title
Yang-33
force-pushed
the
read-package-version
branch
from
e1978cf to
ca638b8
Compare
Yang-33
force-pushed
the
read-package-version
branch
from
ca638b8 to
53ea5b9
Compare
Yang-33
commented
Oct 10, 2023
| @@ -15,7 +15,7 @@ | |||
| """Meta data of line-bot-sdk.""" | |||
|
|
|||
|
|
|||
| __version__ = '3.5.0' | |||
| __version__ = "__LINE_BOT_SDK_PYTHON_VERSION__" | |||
tokuhirom
reviewed
Oct 10, 2023
| python generate-code.py | ||
| - name: Update version in linebot/__about__.py | ||
| run: | | ||
| sed -i 's/__version__ = "__LINE_BOT_SDK_PYTHON_VERSION__"/__version__ = "12.34.5"/g' linebot/__about__.py |
There was a problem hiding this comment.
I should have written why this uses 12.34.5...
Tox (test library) rejects running test if version is illegal. As a workaround, this embeds dummy version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#526
To make release easier, this pull request
__version__defined inlinebot/__about__.py.__verison__with${{ github.event.release.tag_name }}before uploading python package on release. (ref: line-bot-java-sdk)If this change is merged, all we have to do can be