Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration for Audience Group management #250

Merged
merged 1 commit into from
May 4, 2021

Conversation

o926428377
Copy link
Contributor

@o926428377 o926428377 commented Apr 3, 2020

@o926428377 o926428377 force-pushed the master branch 5 times, most recently from 53c6f59 to e60776a Compare April 3, 2020 12:42
@o926428377
Copy link
Contributor Author

Hello @be-hase ,
May I have your review on this pull request ?

linebot/models/responses.py Outdated Show resolved Hide resolved
@tkgauri
Copy link
Contributor

tkgauri commented Jun 10, 2020

@o926428377 could you fix review comments?

@o926428377
Copy link
Contributor Author

@o926428377 could you fix review comments?

Sure, I thought it would be fixed in few days or a week

@o926428377 o926428377 force-pushed the master branch 3 times, most recently from 528a47c to 6c6b984 Compare June 13, 2020 04:00
@o926428377 o926428377 closed this Jun 13, 2020
@o926428377 o926428377 reopened this Jun 13, 2020
@okue okue added this to the 1.17.0 milestone Jun 26, 2020
linebot/api.py Outdated Show resolved Hide resolved
@o926428377 o926428377 force-pushed the master branch 2 times, most recently from 010719c to f7e0e68 Compare July 2, 2020 17:23
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
@o926428377 o926428377 force-pushed the master branch 4 times, most recently from c7bfe23 to d04ab51 Compare August 10, 2020 19:23
@okue okue modified the milestones: 1.17.0, 1.18.0 Sep 2, 2020
@louis70109 louis70109 modified the milestones: 1.18.0, 2.0.0 Dec 13, 2020
@louis70109
Copy link
Member

@o926428377 Sorry for the late response, please help to rebase this PR

linebot/api.py Outdated Show resolved Hide resolved
linebot/models/responses.py Outdated Show resolved Hide resolved
@o926428377 o926428377 force-pushed the master branch 4 times, most recently from dbb86f6 to ccdc2cb Compare December 26, 2020 12:48
@o926428377
Copy link
Contributor Author

@o926428377 Sorry for the late response, please help to rebase this PR

@o926428377 o926428377 closed this Dec 27, 2020
@o926428377
Copy link
Contributor Author

@o926428377 Sorry for the late response, please help to rebase this PR

@louis70109
It's OK. Give my appreciate to Evan for his help.

@o926428377 o926428377 reopened this Dec 27, 2020
Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the spec has Request and Response,
please add test cases to tests/,
let's add qualities for SDK 🙂.
For more test cases you could refer https://github.com/line/line-bot-sdk-python/tree/master/tests

I appreciate your contribution!

linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
linebot/api.py Outdated Show resolved Hide resolved
@o926428377 o926428377 force-pushed the master branch 5 times, most recently from 0bee49e to ebefb74 Compare March 23, 2021 12:44
@louis70109 louis70109 removed this from the 2.0.0 milestone Mar 24, 2021
Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@louis70109 louis70109 merged commit 764c1b4 into line:master May 4, 2021
@louis70109 louis70109 mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants