Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support narrowcast api #241

Merged
merged 14 commits into from
Feb 26, 2020
Merged

support narrowcast api #241

merged 14 commits into from
Feb 26, 2020

Conversation

clsung
Copy link
Contributor

@clsung clsung commented Feb 12, 2020 •
edited
Loading

@clsung
Copy link
Contributor Author

clsung commented Feb 12, 2020

Some comments will be updated when official English translation is released.

This section will be translated into English soon.

cryeo
cryeo suggested changes Feb 14, 2020
View reviewed changes
Copy link
Member

@cryeo cryeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
I just leaved some comments, please check.
(and please update docs after English documentation is released)

linebot/api.py Outdated Show resolved Hide resolved
linebot/models/limit.py Outdated Show resolved Hide resolved
linebot/models/operator.py Outdated Show resolved Hide resolved
linebot/models/operator.py Outdated Show resolved Hide resolved
@tkgauri tkgauri requested a review from okue February 21, 2020 03:18
@okue
Copy link
Member

okue commented Feb 23, 2020

Now, you can update!

Some comments will be updated when official English translation is released.

This section will be translated into English soon.

okue
okue reviewed Feb 23, 2020
View reviewed changes
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

linebot/api.py Show resolved Hide resolved
@clsung clsung requested a review from cryeo February 24, 2020 12:58
cryeo
cryeo reviewed Feb 24, 2020
View reviewed changes
linebot/api.py Outdated Show resolved Hide resolved
okue
okue approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@okue okue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits #241 (comment)

@okue okue requested a review from cryeo February 25, 2020 13:15
@okue
Copy link
Member

okue commented Feb 26, 2020

Thanks @clsung!

@okue okue merged commit 91300c1 into line:master Feb 26, 2020
@clsung clsung deleted the narrowcast branch February 29, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okue okue okue approved these changes

@cryeo cryeo cryeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clsung @okue @cryeo