Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map representation of ID Token and upgrade flutter platform #33

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

onevcat
Copy link
Member

@onevcat onevcat commented Jun 30, 2020

This is the following enchancement for #31, by providing a Map representation of ID Token, so users can access the value there without decoding themselves.

It is also containing some platform things to make it build without warning.

@plateaukao Can you review it when you have time?

@onevcat onevcat requested a review from plateaukao June 30, 2020 02:04
Copy link
Member

@plateaukao plateaukao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit comment.

@@ -149,8 +151,12 @@ class _HomePageState extends State<HomePage>
.login(scopes: _selectedScopes.toList(), option: loginOption);
final accessToken = await LineSDK.instance.currentAccessToken;

final idToken = result.accessToken.idToken;
final userEmail = (idToken != null) ? idToken["email"] : null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single quote for string idToken['email']

@plateaukao plateaukao merged commit 453bf07 into master Jun 30, 2020
@plateaukao plateaukao deleted the feature/json-based-id-token branch June 30, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants