Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: com.linecorp.armeria.client.ContextCancellationTest.cancel_beforeWriteFinished(TestInfo) #5868

Closed
ikhoon opened this issue Aug 12, 2024 · 2 comments
Closed

Test failure: com.linecorp.armeria.client.ContextCancellationTest.cancel_beforeWriteFinished(TestInfo) #5868

ikhoon opened this issue Aug 12, 2024 · 2 comments
Labels
cleanup
Milestone
1.30.0

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Aug 12, 2024 

java.lang.AssertionError: 
Expecting empty but was: [[creqId=5d73bf85][http://127.0.0.1:45623/#GET]]
	at com.linecorp.armeria.client.ContextCancellationTest.validateCallbackChecks(ContextCancellationTest.java:289)
	at com.linecorp.armeria.client.ContextCancellationTest.cancel_beforeWriteFinished(ContextCancellationTest.java:259)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
@jrhee17
Copy link
Contributor

jrhee17 commented Aug 12, 2024

😿 Feel free to proceed with the release ignoring this test failure. Let me handle this once my backlog is a little less full

@jrhee17 jrhee17 mentioned this issue Aug 12, 2024
Merged
ikhoon pushed a commit that referenced this issue Aug 12, 2024
@jrhee17
Fix flaky test ContextCancellationTest (#5869)
4f17989 
Motivation:

Let me just remove the validation like @minwoox suggested

Modifications:

- Removed the validation on request context.

Result:

- #5868

<!--
Visit this URL to learn more about how to write a pull request
description:

https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
@jrhee17 jrhee17 added this to the 1.30.0 milestone Aug 13, 2024
@jrhee17
Copy link
Contributor

jrhee17 commented Aug 13, 2024

Closing this issue since the test was fixed

@jrhee17 jrhee17 closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
1.30.0
Development

No branches or pull requests
2 participants
@ikhoon @jrhee17