Update

line · Dec 18, 2024 · 1033e04 · 1033e04
1 parent 5dc5aae
commit 1033e04
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/core/src/main/java/com/linecorp/armeria/common/logging/DefaultLogWriter.java b/core/src/main/java/com/linecorp/armeria/common/logging/DefaultLogWriter.java
@@ -114,11 +114,7 @@ public void logResponse(RequestLog log) {
                     responseLogLevel.log(logger, logFormatter.formatRequest(log));
                 }
 
-                if (responseCause == null) {
-                    responseLogLevel.log(logger, responseStr);
-                    return;
-                }
-                if (responseCauseFilter.test(ctx, responseCause)) {
+                if (responseCause == null || responseCauseFilter.test(ctx, responseCause)) {
                     responseLogLevel.log(logger, responseStr);
                 } else {
                     responseLogLevel.log(logger, responseStr, responseCause);
@@ -135,8 +131,9 @@ static boolean isSuccess(RequestLog log) {
         } else if (ctx instanceof ServiceRequestContext) {
             successFunction = ((ServiceRequestContext) ctx).config().successFunction();
         } else {
-            throw new IllegalStateException(
-                    ctx + " is neither ClientRequestContext nor ServiceRequestContext");
+            throw new IllegalArgumentException(
+                    ctx + " is neither " + ClientRequestContext.class.getSimpleName() + " nor " +
+                    ServiceRequestContext.class.getSimpleName());
         }
         return successFunction.isSuccess(ctx, log);
     }