Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments inside JSON block #437

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Remove comments inside JSON block #437

merged 1 commit into from
Feb 26, 2024
+4 −4

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Feb 26, 2024 •
edited
Loading

Change Description

Closes #435

Checklist

  • This PR is meant for the lincc-frameworks/python-project-template repo and not a downstream one instead.
  • This change is linked to an open issue
  • This change includes integration testing, or is small enough to be covered by existing tests

camposandro
camposandro approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit e5b0402 into main Feb 26, 2024
5 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/435/json branch February 26, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camposandro camposandro camposandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments in slackbot message invalidate JSON
2 participants
@delucchi-cmu @camposandro