Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pack_lists for multiple-chunk series #181

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Fix pack_lists for multiple-chunk series #181

merged 2 commits into from
Dec 19, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Dec 19, 2024

Closes #180

@hombit hombit requested a review from gitosaurus December 19, 2024 18:53
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (3cb19bd) to head (5d39c52).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          13       13           
  Lines        1062     1071    +9     
=======================================
+ Hits         1056     1065    +9     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 19, 2024

Before [3cb19bd] After [a8c41a0] Ratio Benchmark (Parameter)
43.9±8ms 31.8±8ms ~0.73 benchmarks.ReassignHalfOfNestedSeries.time_run
23.1±0.5ms 23.3±0.1ms 1.01 benchmarks.AssignSingleDfToNestedSeries.time_run
15.1±0.1ms 15.2±0.2ms 1.01 benchmarks.NestedFrameQuery.time_run
263M 264M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
85.8M 86.1M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
90.8M 91M 1.00 benchmarks.NestedFrameQuery.peakmem_run
89.4M 89.8M 1.00 benchmarks.NestedFrameReduce.peakmem_run
283M 283M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
1.43±0.01ms 1.42±0.02ms 0.99 benchmarks.NestedFrameReduce.time_run
9.43±0.1ms 9.23±0.05ms 0.98 benchmarks.NestedFrameAddNested.time_run

Click here to view all benchmarks.

@gitosaurus gitosaurus self-requested a review December 19, 2024 19:17
@hombit hombit merged commit 27dd430 into main Dec 19, 2024
8 checks passed
@hombit hombit deleted the fix-from-lists branch December 19, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when nesting lists
2 participants