Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support set font size text use pixel unit #25

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Support set font size text use pixel unit #25

merged 1 commit into from
Oct 16, 2023

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Oct 13, 2023

Issue

  • By default document.execCommand("fontSize", value); only supports values in the range 1->7. So we need to use a bit of javascript and css to handle the desired fontSize.

Resolved

Screen.Recording.2023-10-13.at.19.01.29.mov

@dab246 dab246 mentioned this pull request Oct 14, 2023
Merged
@dab246 dab246 merged commit 96c199b into email_supported Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@hieutbui hieutbui Awaiting requested review from hieutbui

@nqhhdev nqhhdev Awaiting requested review from nqhhdev

@sherlockvn sherlockvn Awaiting requested review from sherlockvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dab246 @hoangdat