Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger.warning -> logger.warn #2691

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

invakid404
Copy link
Contributor

Description

This PR fixes a typo in the search service that references a non-existent logger method.

Related Issue

Fixes #2690.

Motivation and Context

It allows twake-node to be deployed without a search service.

How Has This Been Tested?

I've successfully deployed twake-node locally without configuring a search service.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@RomaricMourgues
Copy link
Contributor

Hi, thank you very much for this fix, could you rebase the PR to the develop branch ?
Romaric

Signed-off-by: Tsvetomir Bonev <invakid404@riseup.net>
@invakid404 invakid404 changed the base branch from main to develop January 18, 2023 10:26
@invakid404
Copy link
Contributor Author

Hi, thank you very much for this fix, could you rebase the PR to the develop branch ? Romaric

Sure thing, it's done :^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deploy twake-node without configuring a search service
2 participants