🛠 Fix scroll glitches and implement jump to message feature #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RomaricMourgues
commented
Apr 25, 2022
•
RomaricMourgues
commented
- Thumbnail are rotated when from mobile #2111
- Highlight and scroll to requested message in channel and thread view using router
- Fix Fix broken tests (dependancy issue) #2123
- Scroll back to bottom button
- Scroll is SO RANDOM
- Put back loader
- Repeat for threads
- Realtime is broken now
- Missing first message in thread view
- When scrolling up we are stuck to the top and so it scroll to the top indefinitively
- Channel initial message ?
- When sending a message the message is duplicated
RomaricMourgues
changed the title
…scroll-glitches
…scroll-glitches
RomaricMourgues
added a commit
that referenced
this pull request
May 10, 2022
* Try to reduce glitches * Fix rotation of thumbnails * Still not working but at least virtuoso is updated * Create use-highlight-message * Ability to jump to message from url * Super buggy but works * Clean url if channel change * Finaly something kind of working 🎉 * Duplicate work for threads * Fix dependancies * Implement "Go to last message" button * Make sure we don't set time at wrong place * Improving as we can * Put back real time partially * Update useEffect to useGlobalEffect * Almost fully working ! * Fix load to top issue and realtime issue * Put back thread initial message * Fix frontend message duplicated * Remove console.log * Clean code
github-actions
bot
removed
qa:ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.