Show progress only when logging to terminal #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the pb.Start() does not start the ticker and never write anything: https://github.com/cheggaaa/pb/blob/master/v3/pb.go#L173 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Logging progress to file is not useful and it also breaks the log format, adding empty line before the first progress, and leaving the last progress at the start of the next log line. Fix the terminal check to use os.Stderr, since both pb and logrus use os.Stderr. When not using a terminal, hide the progress bar. Fixes lima-vm#2581 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
force-pushed
the
progress-to-file
branch
from
74b3fcd to
3fcc54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the terminal check so we use the right configuration when logging to file, and hide the progress in this case.
Fixes #2581