Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.yml: use inject-cmdline-to-template.sh to append no_timer_check kernel command line option #2541

Merged

Conversation

norio-nomura
Copy link
Contributor

@norio-nomura norio-nomura commented Aug 10, 2024

This change aims to avoid kernel panics in the integration tests and the vmnet tests.

==> /Users/runner/.lima/default/serial.log <==
[    0.015000]  setup_IO_APIC+0x2c3/0x370
[    0.015000]  ? enable_IO_APIC+0x1af/0x290
[    0.015000]  apic_intr_mode_init+0x61/0x130
[    0.015000]  x86_late_time_init+0x24/0x40
[    0.015000]  start_kernel+0x2be/0x450
[    0.015000]  x86_64_start_reservations+0x18/0x30
[    0.015000]  x86_64_start_kernel+0xbf/0x110
[    0.015000]  secondary_startup_64_no_verify+0x184/0x18b
[    0.015000]  </TASK>
[    0.015000] ---[ end Kernel panic - not syncing: IO-APIC + timer doesn't work!  Boot with apic=debug and send a report.  Then try booting with the 'noapic' option. ]---

The reason no_timer_check is used instead of noapic, as shown in the kernel panic log, is because I read the following page.
https://lore.kernel.org/all/18354be1-8dba-84f1-bdf5-6821a5013d78@oracle.com/T/

examples/default.yaml Outdated Show resolved Hide resolved
@norio-nomura norio-nomura force-pushed the use-no_timer_check-kernel-parameter branch from 4937906 to 2410ffa Compare August 17, 2024 03:22
@norio-nomura norio-nomura changed the title default.yaml: Use no_timer_check kernel parameter test.yml: use inject-cmdline-to-template.sh to append no_timer_check kernel command line option Aug 17, 2024
@norio-nomura norio-nomura marked this pull request as ready for review August 17, 2024 03:51
…ck` kernel command line option

This change aims to avoid kernel panics in the integration tests and vmnet tests.
```console
==> /Users/runner/.lima/default/serial.log <==
[    0.015000]  setup_IO_APIC+0x2c3/0x370
[    0.015000]  ? enable_IO_APIC+0x1af/0x290
[    0.015000]  apic_intr_mode_init+0x61/0x130
[    0.015000]  x86_late_time_init+0x24/0x40
[    0.015000]  start_kernel+0x2be/0x450
[    0.015000]  x86_64_start_reservations+0x18/0x30
[    0.015000]  x86_64_start_kernel+0xbf/0x110
[    0.015000]  secondary_startup_64_no_verify+0x184/0x18b
[    0.015000]  </TASK>
[    0.015000] ---[ end Kernel panic - not syncing: IO-APIC + timer doesn't work!  Boot with apic=debug and send a report.  Then try booting with the 'noapic' option. ]---
```

The reason `no_timer_check` is used instead of `noapic`, as shown in the kernel panic log, is because I read the following page.
https://lore.kernel.org/all/18354be1-8dba-84f1-bdf5-6821a5013d78@oracle.com/T/

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

inject-cmdline-to-template.sh: resolve shfmt issue

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

test.yml: add link to issue

lima-vm#84
Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

inject-cmdline-to-template.sh: add comment lines to explain what this script does

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
@norio-nomura norio-nomura force-pushed the use-no_timer_check-kernel-parameter branch from 1541149 to 9fbd193 Compare August 18, 2024 06:41
@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Aug 18, 2024
@AkihiroSuda AkihiroSuda added this to the v0.23.0 milestone Aug 18, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants