-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing available commands with basic and advanced commands #2167
Replacing available commands with basic and advanced commands #2167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use group ID?
Sorry @AkihiroSuda! Now I made the necessary changes to implement the fix using groupID. I will define constants too |
caa9319
to
9468823
Compare
cmd/limactl/main.go
Outdated
@@ -119,6 +123,7 @@ func newApp() *cobra.Command { | |||
newProtectCommand(), | |||
newUnprotectCommand(), | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded change
cmd/limactl/copy.go
Outdated
|
||
Prefix guest filenames with the instance name and a colon. | ||
|
||
Example: limactl copy default:/etc/os-release . | ||
` | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded changes
Thanks, but please squash commits |
9468823
to
5c46f0a
Compare
Thank you for reviewing @AkihiroSuda. Now I have squashed the commits. |
Signed-off-by: Ayush <ayush.gupta2020c@vitstudent.ac.in>
5c46f0a
to
1595639
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This pull request closes:
Changes made:
SetHelpFunc
printCommands
to print all the commands. Used the function inSetHelpFunc
.Output of
limactl help
after changes: