Fix GuestAgentConn vsock support #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
1 task
pendo324
added a commit
to runfinch/finch-core
that referenced
this pull request
Jan 9, 2024
…agent communication (#227) Issue #, if available: e2e test failures on runfinch/finch#649 *Description of changes:* - Track Lima commit that fixes underlying issue with guestagent communication, which ultimately breaks port forwarding (which is why the e2e tests are failing). See lima-vm/lima#2118 for more details *Testing done:* - tested on a Windows machine by compiling Lima - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When how Lima connects to the guest agent was refactored in #1998, https://github.com/mdlayher/vsock was used to support vsock connections on Windows, but the library doesn't support Windows. The following error log is from a WSL Lima instance on v0.19.1:
The corresponding log from the library is here.
With this change to revert to using winio's Dial, guestagent communication works as it did previously.
More information on the how the HyperV/Windows vsock support works (can add this to the comment in wsl_driver too):
Also un-exported
MagicVSOCKSuffixsince it's now only used in the windows package.