Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure user provisioning scripts can be executed #197

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

jandubois
Copy link
Member

There are 2 issues:

  • a typo (note the double }}) made the waiting loop run forever:

    until [ -e "/run/user/${LIMA_CIDATA_UID}}/systemd/private" ]; do sleep 3; done
    
  • the user scripts are owned by root with mode 700 on /mnt/lima_cidata/... so not accessible by the regular user

This commit copies them into the home directory (and deletes them after execution)

Fixes #192

There are 2 issues:

* a typo (note the double "}}") made the waiting loop run forever:

  until [ -e "/run/user/${LIMA_CIDATA_UID}}/systemd/private" ]; do sleep 3; done

* the user scripts are owned by root with mode 700 on /mnt/lima_cidata/... so
  not accessible by the regular user

This commit copies them into the home directory (and deletes them after execution)

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
@jandubois jandubois added the bug Something isn't working label Sep 3, 2021
@AkihiroSuda AkihiroSuda added this to the v0.6.2 milestone Sep 3, 2021
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should have CI for this, but can be another PR

@AkihiroSuda AkihiroSuda merged commit 950be8a into lima-vm:master Sep 3, 2021
@jandubois jandubois deleted the user-provision branch September 3, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User mode provisioning doesn't seem to be running?
2 participants