Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu-img 6.1.0 no longer supports using -b without -F #174

Merged
merged 1 commit into from
Aug 28, 2021
Merged

qemu-img 6.1.0 no longer supports using -b without -F #174

merged 1 commit into from
Aug 28, 2021

Conversation

jandubois
Copy link
Member

Backing file specified without backing format
Detected format of qcow2.

@jandubois
qemu-img 6.1.0 no longer supports using -b without -F
ac49903 
> Backing file specified without backing format
> Detected format of qcow2.

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
AkihiroSuda
AkihiroSuda reviewed Aug 28, 2021
View reviewed changes
pkg/qemu/qemu.go
@@ -78,7 +78,7 @@ func EnsureDisk(cfg Config) error {
}
args := []string{"create", "-f", "qcow2"}
if !isBaseDiskISO {
args = append(args, "-b", baseDisk)
args = append(args, "-F", "qcow2", "-b", baseDisk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

question: does -F qcow2 work when the base image is non-qcow2 (especially raw)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I suspect it won't. :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we inspect the format?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #176 for detecting the format

@AkihiroSuda AkihiroSuda added this to the v0.6.1 milestone Aug 28, 2021
@AkihiroSuda AkihiroSuda merged commit a2045a1 into lima-vm:master Aug 28, 2021
@jandubois jandubois deleted the qemu-6.1 branch August 28, 2021 06:17
@AkihiroSuda AkihiroSuda mentioned this pull request Aug 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
priority/high
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jandubois @AkihiroSuda