Support digest validation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
dev-new-downloader
branch
4 times, most recently
from
1eb14fb to
0dbfbcf
Compare
jandubois
reviewed
Jul 3, 2021
There was a problem hiding this comment.
Looks fine to me, but I'm in a bit of a hurry right now and didn't look too closely. Will be mostly offline the next 2 days.
One thought (for a later PR) would be to support downloadable checksums. They obviously don't protect against a website spoofing attack, but still help with truncated downloads due to networking errors.
E.g. checking https://cloud-images.ubuntu.com/hirsute/current/SHA256SUMS, but maybe there are too many different formats to support for that?
|
Yes, I was thinking of that. |
AkihiroSuda
force-pushed
the
dev-new-downloader
branch
2 times, most recently
from
58def41 to
2a25071
Compare
Also removes dependency on `curl` binary Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
dev-new-downloader
branch
from
2a25071 to
ee4e080
Compare
|
Merging and releasing v0.5.0. Support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes dependency on
curlbinary