Fix undefined cname race condition

Co-authored-by: Jan Dubois <jan@jandubois.com>
lima-vm · Oct 20, 2021 · 19ebfb6 · 19ebfb6
1 parent dbc04dc
commit 19ebfb6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/hostagent/dns.go b/pkg/hostagent/dns.go
@@ -76,7 +76,10 @@ func (h *Handler) handleQuery(w dns.ResponseWriter, req *dns.Msg) {
 		switch q.Qtype {
 		case dns.TypeCNAME, dns.TypeA, dns.TypeAAAA:
 			cname, err := net.LookupCNAME(q.Name)
-			if err == nil && cname != "" && cname != q.Name {
+			if err != nil {
+				break
+			}
+			if cname != "" && cname != q.Name {
 				hdr.Rrtype = dns.TypeCNAME
 				a := &dns.CNAME{
 					Hdr:    hdr,