-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the system-monitor
applet
#626
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this contribution! There's a few minor nits, but otherwise this looks great :)
resolve the duplicate dependency issue
This will be fixed in Nixpkgs via NixOS/nixpkgs#282798 but you can also bug upstream to add a line like this to their Cargo.toml to fix it: https://github.com/cosmic-utils/tasks/blob/406ffac6a2263cdc1006f3578b3f9be64761d6ea/Cargo.toml#L50-L51
Thanks for the review! Sorry for blindly copying some useless stuff from another applet. I pushed a non-working WIP branch, as I still don't understand where to get |
Co-authored-by: Lily Foster <lily@lily.flowers>
Co-authored-by: Lily Foster <lily@lily.flowers>
Co-authored-by: Lily Foster <lily@lily.flowers>
Co-authored-by: Lily Foster <lily@lily.flowers>
Closes #625
TODO:
cosmic-client-toolkit
depends onregistry+https://github.com/rust-lang/crates.io-index#smithay-client-toolkit@0.19.2
cosmic-panel-config
depends ongit+https://github.com/Smithay/client-toolkit#smithay-client-toolkit@0.19.2
git
?buildRustPackage
fails because the same version of a crate is added twice. same error as here.cosmic-panel-config
has transitive dependency on smithay pop-os/cosmic-panel#4